Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid
......................................................................
Patch Set 67:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt:
https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte...
PS66, Line 4: ,3
: K4AAG165WA-BCWE,4
: MT40A1G16KD-062E:E,5
Posted comment on bug too.
They requested specific DRAM IDs when they requested the additional three parts in https://b.corp.google.com/issues/161772961#comment35. I asked if they really needed them or not, but did not get a response back quickly enough, and after re-reading their comments, it seemed clear they were asking for those parts to be assigned specific IDs, so I made the change (I'm OOO for the next 10 days, so was trying to finish this up before I have to leave, so I moved forward without an answer).
They have responded that what I had before making the IDs match their request was sufficient (0-2 specified, the rest chosen by the tool), so I will revert back to that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44272
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66
Gerrit-Change-Number: 44272
Gerrit-PatchSet: 67
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mice Lin
mice_lin@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 28 Aug 2020 18:04:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment