Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33823 )
Change subject: src: Use standard <inttypes.h>
......................................................................
Patch Set 8:
I would prefer to just copy/adapt (s/j/ll/) the useful
parts.
Implementing j in vtxprintf() is very easy (CB:34027), so we can just copy-paste those parts.
That would be the PRI* macros, if need be also the SCN*
ones, but definitely no abandoned `#if 0` block full of
clang-format training excercises.
Agreed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33823
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e3a300f9b1c38e4831b030ff8af3fed2fa60f14
Gerrit-Change-Number: 33823
Gerrit-PatchSet: 8
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 03 Jul 2019 19:00:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment