Attention is currently required from: Frank Chu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58162 )
Change subject: mb/google/dedede/var/galtic: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58162/comment/a232af9f_895aa1bf
PS1, Line 11: Define SSFC bit 9-11 in coreboot for codec within ec.
Please update this as "Define FW_CONFIG bits 41 - 43 (SSFC bits 9 - 11) for codec selection."
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58162
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaba136a836b89f42411474ae733380e345cce687
Gerrit-Change-Number: 58162
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Fri, 08 Oct 2021 04:44:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment