Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48315 )
Change subject: soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops ......................................................................
soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops
Now pci_domain_ops in chip.c can also be marked as static.
Change-Id: Ia92b778a5882d991b391dc29aeee0a5615677913 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48315 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/chip.c M src/soc/amd/picasso/chip.h 2 files changed, 1 insertion(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/picasso/chip.c b/src/soc/amd/picasso/chip.c index 8384541..d31e94a 100644 --- a/src/soc/amd/picasso/chip.c +++ b/src/soc/amd/picasso/chip.c @@ -55,7 +55,7 @@ return NULL; };
-struct device_operations pci_domain_ops = { +static struct device_operations pci_domain_ops = { .read_resources = pci_domain_read_resources, .set_resources = pci_domain_set_resources, .scan_bus = pci_domain_scan_bus, diff --git a/src/soc/amd/picasso/chip.h b/src/soc/amd/picasso/chip.h index 28d2040..412cc08 100644 --- a/src/soc/amd/picasso/chip.h +++ b/src/soc/amd/picasso/chip.h @@ -223,6 +223,4 @@
typedef struct soc_amd_picasso_config config_t;
-extern struct device_operations pci_domain_ops; - #endif /* __PICASSO_CHIP_H__ */