Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36845 )
Change subject: security/vboot: Remove vboot_set_selected_region() ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/common.c... PS1, Line 122: vboot_named_region_device This would be a separate CL if we decide to fix it but -- I wonder why we have both security/vboot/common.c and security/vboot/vboot_common.c? There's only a few functions in vboot_common.c -- perhaps we should merge them into this file.
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/misc.h File src/security/vboot/misc.h:
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/misc.h@5... PS1, Line 53: const struct vb2_context *ctx I wonder if we really need to pass the context object around in coreboot (same for the function below). Perhaps we should just call vboot_get_context() whenever it is needed locally. Julius, what is your preference?
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/misc.h@5... PS1, Line 54: vboot_locate_firmware I wonder if we should still call this new function "vboot_get_selected_region"?