Attention is currently required from: Felix Singer, Angel Pons, Iru Cai, Iru Cai (vimacs). Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54744 )
Change subject: Documentation: add Intel Broadwell ......................................................................
Patch Set 5: Code-Review+1
(4 comments)
Patchset:
PS5: Thank you for writing this.
File Documentation/soc/intel/broadwell/blobs.md:
https://review.coreboot.org/c/coreboot/+/54744/comment/d9941c6f_32439805 PS5, Line 18: ```bash : cbfstool coreboot_*.rom extract -f broadwell-mrc.bin -n mrc.bin : cbfstool coreboot_*.rom extract -m x86 -f broadwell-refcode.elf -n fallback/refcode : ``` I’d just indent it by four spaces.
https://review.coreboot.org/c/coreboot/+/54744/comment/b20435d5_9c31a311 PS5, Line 25: is are (referring to addresses)?
https://review.coreboot.org/c/coreboot/+/54744/comment/d6f38ba0_0a4efffe PS5, Line 31: of `refcode` is needed. The device does not work otherwise?