[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/brox/jubilant: Tune I2C timing

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84143?usp=email )

Change subject: mb/google/brox/jubilant: Tune I2C timing
......................................................................

mb/google/brox/jubilant: Tune I2C timing

Tune I2C2 timing:
Set falling time to 250ns from 400ns to meet spec: "THIGH>0.6us"

BUG=b:362685374
TEST= Build jubilant firmware
      Measure the i2c signal on jubilant to meet spec:
      I2C2 THIGH from 0.494 us to 0.76 us

Change-Id: I42a60edc0b361bfabacf5376ef89f436efedb356
Signed-off-by: Ren Kuo 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84143
Reviewed-by: Subrata Banik 
Reviewed-by: Bob Moragues 
Reviewed-by: Kenneth Chan 
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Karthik Ramasubramanian 
---
M src/mainboard/google/brox/variants/jubilant/overridetree.cb
1 file changed, 39 insertions(+), 0 deletions(-)

Approvals:
  Bob Moragues: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified
  Subrata Banik: Looks good to me, but someone else must approve
  Kenneth Chan: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/brox/variants/jubilant/overridetree.cb b/src/mainboard/google/brox/variants/jubilant/overridetree.cb
index 2f6f83b..f6dac2f 100644
--- a/src/mainboard/google/brox/variants/jubilant/overridetree.cb
+++ b/src/mainboard/google/brox/variants/jubilant/overridetree.cb
@@ -37,6 +37,45 @@
    register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC2)"     # Type A port A0(DCI)
    register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC_SKIP)" # WWAN

+	# Intel Common SoC Config
+	#+-------------------+---------------------------+
+	#| Field             |  Value                    |
+	#+-------------------+---------------------------+
+	#| I2C0              | Trackpad                  |
+	#| I2C1              | Touchscreen               |
+	#| I2C2              | Audio codec & Sar sensor  |
+	#| I2C4              | cr50 TPM. Early init is   |
+	#|                   | required to set up a BAR  |
+	#|                   | for TPM communication     |
+	#+-------------------+---------------------------+
+	register "common_soc_config" = "{
+		.i2c[0] = {
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 650,
+			.fall_time_ns = 330,
+			.data_hold_time_ns = 50,
+		},
+		.i2c[1] = {
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 600,
+			.fall_time_ns = 350,
+			.data_hold_time_ns = 50,
+		},
+		.i2c[2] = {
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 600,
+			.fall_time_ns = 250,
+			.data_hold_time_ns = 50,
+		},
+		.i2c[4] = {
+			.early_init = 1,
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 650,
+			.fall_time_ns = 400,
+			.data_hold_time_ns = 50,
+		},
+	}"
+
    device domain 0 on
    	device ref dtt on
    		chip drivers/intel/dptf