[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: If using VBOOT, skip the APOB_NV region for RO

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44046 )

Change subject: soc/amd/picasso: If using VBOOT, skip the APOB_NV region for RO
......................................................................

soc/amd/picasso: If using VBOOT, skip the APOB_NV region for RO

When booting from the RO region of a VBOOT enabled ROM, there shouldn't
be a reliance on anything outside of the RO section.  This includes the
APOB_NV region (similar to the MRC cache region).  By skipping the
region when setting up the BIOS Directory table, the PSP won't try to
use the region when booting.

The APOB_NV region is still used for the VBOOT RW sections.

BUG=b:158363448
TEST=Build RO with no APOB_NV region.  Dump the BDT and verify that
it's not in RO, but is in RW_A & RW_B.  Boot into recovery.

Signed-off-by: Martin Roth 
Change-Id: I13c35ba8a2331492744d2acf257db15e4a53102a
---
M src/soc/amd/picasso/Makefile.inc
1 file changed, 11 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/44046/1

diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc
index 4c1d726..ff2db4a 100644
--- a/src/soc/amd/picasso/Makefile.inc
+++ b/src/soc/amd/picasso/Makefile.inc
@@ -323,6 +323,11 @@
 OPT_APOB_NV_SIZE=$(call add_opt_prefix, $(APOB_NV_SIZE), --apob-nv-size)
 OPT_APOB_NV_BASE=$(call add_opt_prefix, $(APOB_NV_BASE),--apob-nv-base)

+ifeq ($(CONFIG_VBOOT),)
+OPT_APOB0_NV_SIZE=$(OPT_APOB_NV_SIZE)
+OPT_APOB0_NV_BASE=$(OPT_APOB_NV_BASE)
+endif
+
 AMDFW_COMMON_ARGS=$(OPT_AMD_PUBKEY_FILE) \
    	$(OPT_PSPBTLDR_FILE) \
    	$(OPT_PSPSCUREOS_FILE) \
@@ -333,8 +338,6 @@
    	$(OPT_SMUFW2_SUB1_FILE) \
    	$(OPT_PSP_APCB_FILES) \
    	$(OPT_APOB_ADDR) \
-		$(OPT_APOB_NV_SIZE) \
-		$(OPT_APOB_NV_BASE) \
    	$(OPT_PSP_BIOSBIN_FILE) \
    	$(OPT_PSP_BIOSBIN_DEST) \
    	$(OPT_PSP_BIOSBIN_SIZE) \
@@ -458,6 +461,8 @@
    @printf "    AMDFWTOOL  $(subst $(obj)/,,$(@))\n"
    $(AMDFWTOOL) \
    	$(AMDFW_COMMON_ARGS) \
+		$(OPT_APOB0_NV_SIZE) \
+		$(OPT_APOB0_NV_BASE) \
    	--location $(shell printf "%#x" $(PICASSO_FWM_POSITION)) \
    	--output $@

@@ -472,6 +477,8 @@
    @printf "    AMDFWTOOL  $(subst $(obj)/,,$(@))\n"
    $(AMDFWTOOL) \
    	$(AMDFW_COMMON_ARGS) \
+		$(OPT_APOB_NV_SIZE) \
+		$(OPT_APOB_NV_BASE) \
    	--location $(shell printf "%#x" $(CONFIG_PICASSO_FW_A_POSITION)) \
    	--anywhere \
    	--output $@
@@ -481,6 +488,8 @@
    @printf "    AMDFWTOOL  $(subst $(obj)/,,$(@))\n"
    $(AMDFWTOOL) \
    	$(AMDFW_COMMON_ARGS) \
+		$(OPT_APOB_NV_SIZE) \
+		$(OPT_APOB_NV_BASE) \
    	--location $(shell printf "%#x" $(CONFIG_PICASSO_FW_B_POSITION)) \
    	--anywhere \
    	--output $@