Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32234 )
Change subject: vboot: do not set VBSD_BOOT_FIRMWARE_WP_ENABLED flag
......................................................................
Patch Set 1: Code-Review-1
Did you really double-check for *all* Chrome OS boards that the "write protect" lb_gpio is defined and initialized to represent the same (when combined with polarity) as what get_write_protect_state() returns? I wouldn't be so sure that's always the case, errors can easily creep in. (For example, in cheza/chromeos.c I think the polarity got messed up.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32234
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d24a057b1385244a836a67c565ee6726a894fdc
Gerrit-Change-Number: 32234
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Apr 2019 22:59:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment