[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: Add gpio-keys ACPI node for PENH

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43764 )

Change subject: mb/google/volteer: Add gpio-keys ACPI node for PENH
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43764/5/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/volteer/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43764/5/src/mainboard/google/voltee... 
PS5, Line 74: EDGE_BOTH
> yeah, it's just confusing here when we have to select which trigger type it is. […]

That's exactly what I meant. That said, I think the important bit is noting that falling or rising edge cooresponds to key.linux_code. And the wake through SCI pin corresponds to signal polarity for eject. Maybe we should have some encapsulating driver that for garaged stylus that conveys all the things we want to provide. Not for this change, but that way alleviate the confusion.