Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41420 )
Change subject: lib: Add strtok() and strtok_r()
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41420/3/src/lib/string.c
File src/lib/string.c:
https://review.coreboot.org/c/coreboot/+/41420/3/src/lib/string.c@194
PS3, Line 194: char *start
Just want to add that as far as I know, we have no rule against C99 declarations in coreboot. […]
Yes, you are right Julius.
I still have this C90 style deep in my bones. But yes, there is no written rule or the like.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41420
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic855b31669be1c274cbf247c53ffa6f74ec5bf35
Gerrit-Change-Number: 41420
Gerrit-PatchSet: 6
Gerrit-Owner: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Sindhoor Tilak
sindhoor@sin9yt.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 19 May 2020 11:17:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-MessageType: comment