[coreboot-gerrit] Change in coreboot[master]: drivers/spi/tpm: Re-organize the TPM Initialization

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44276 )

Change subject: drivers/spi/tpm: Re-organize the TPM Initialization
......................................................................

Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/44276/2/src/drivers/spi/tpm/tpm.c 
File src/drivers/spi/tpm/tpm.c:

https://review.coreboot.org/c/coreboot/+/44276/2/src/drivers/spi/tpm/tpm.c@4... 
PS2, Line 450: } while (vstr[chunk_count * chunk_size - 1] &&
             : 		 (chunk_count + 1) * chunk_size < sizeof(vstr));
I find this loop construct overly complex for what it is trying to achieve. At minimum I would take the upper bound portion of this boundary predicate and make it into a if-break construction in the loop body.

https://review.coreboot.org/c/coreboot/+/44276/2/src/drivers/spi/tpm/tpm.c@4... 
PS2, Line 452: 0
'\0' as vstr is char typed.