Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44678 )
Change subject: Revert "vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller"
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
I see you are reusing the upd field offset.
that was used in the sata change, but apart from the coreboot upd field that shouldn't have been submitted, but got submitted, this wasn't used anywhere. the intention to use this byte for the hda enablement is tohave the audio settings grouped together
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44678
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If79900f3a92fd949d7653001e1ca2faac7061e3c
Gerrit-Change-Number: 44678
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 21 Aug 2020 18:47:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment