Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35880 )
Change subject: src/soc/intel: FSP2.0 platforms: add mainboard option to skip graphics init
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3:
Patch Set 2:
(6 comments)
Started to review, but erm, sorry, this is a mess. There's
a list in the commit message. Which is asking me to ask you
to split it into separate commits.
The first two of the list, are the same change.....
It wouldn't make sense to add a Kconfig without functionality^^
... and the third change is dropping two tiny lines, that are replaced by the rest. So I really don't see a reason to split this...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35880
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3bd7f3dc4c795691a04d2eaba0e2458ee50aabb
Gerrit-Change-Number: 35880
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Hung-Te Lin
hungte@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Naresh Solanki
naresh.solanki.2011@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 25 Oct 2019 23:17:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment