Attention is currently required from: Jan Dabros, Werner Zeh. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57555 )
Change subject: tests: Add lib/lzma-test test case ......................................................................
Patch Set 7:
(3 comments)
File tests/lib/lzma-test.c:
https://review.coreboot.org/c/coreboot/+/57555/comment/e8cf5cd1_13f525d7 PS6, Line 48: /* 9 -> strlen(".lzma.bin") */
nit: Now that you have moved on to ARRAY_SIZE this '9' is a bit confusing.
Oh, thanks. I thought, I removed this comment.
https://review.coreboot.org/c/coreboot/+/57555/comment/475553c5_6caf5bc8 PS6, Line 81: test_free(s->raw_filename); : test_free(s->comp_filename); : test_free(s)
How about calling teardown_ulzman_file() here?
Done
https://review.coreboot.org/c/coreboot/+/57555/comment/314f3af6_0e4791a9 PS6, Line 120: assert_non_null(raw_buf); : assert_non_null(comp_buf);
I guess this test is here for making sure that test_malloc was successful in getting some memory, ri […]
Good find. I forgot to check decomp_buf.