Attention is currently required from: Jonathan Zhang.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72439?usp=email )
Change subject: soc/intel/xeon_sp: add Kconfig file for SPR-SP
......................................................................
Patch Set 8:
(2 comments)
File src/soc/intel/xeon_sp/spr/Kconfig:
https://review.coreboot.org/c/coreboot/+/72439/comment/e6114ce1_2c82099b :
PS8, Line 128: MAX_IMC
maybe I'm wrong, but isn't this defined here intel/fsp/fsp2_0/sapphirerapids_sp/IioUniversalDataHob.h ?
https://review.coreboot.org/c/coreboot/+/72439/comment/bc91ceac_e5f1641a :
PS8, Line 132: MAX_MC_CHN
this is not used
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72439?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14cf115b02d8edff9b48e744b798a3b1ba18b8bf
Gerrit-Change-Number: 72439
Gerrit-PatchSet: 8
Gerrit-Owner: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Comment-Date: Sun, 18 Jun 2023 15:42:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment