Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31813 )
Change subject: Fix up remaining boolean uses of CONFIG_XXX to CONFIG(XXX)
......................................................................
Patch Set 1: Code-Review+2
I guess I can still start a discussion if my concerns
ever become an issue. Also, regarding the original
intention, from the commit message of c0e16e7:
Long term plan is to remove our Kconfig hack to #define values to 0,
and this helps.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31813
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa0573a535addc3354a74e944c0920befb0666be
Gerrit-Change-Number: 31813
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 24 Mar 2019 12:44:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment