[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Add restore and enable GPIO PM

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41712 )

Change subject: soc/intel/common: Add restore and enable GPIO PM
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41712/4/src/soc/intel/common/acpi/g... 
File src/soc/intel/common/acpi/gpio.asl:

https://review.coreboot.org/c/coreboot/+/41712/4/src/soc/intel/common/acpi/g... 
PS4, Line 22: Name(GPMB, Package(TOTAL_GPIO_COMM) {0})
I'm surprised this compiles, the ACPI spec says " It is a compile time error for NumElements to be less than the number of elements defined in the PackageList". So I would expect you would need TOTAL_GPIO_COMM 0s in that Package... could you double check what the output from IASL (the AML) looks like?