Attention is currently required from: Martin Roth. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/62939 )
Change subject: makechips.sh: Reformat script with shfmt ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File makechips.sh:
https://review.coreboot.org/c/em100/+/62939/comment/4f2205f6_6f25747f PS1, Line 17: if ! which curl >/dev/null; then : echo "Install curl to run this script." : exit 1 : fi : if ! which msiextract >/dev/null; then : echo "Install msitools (https://wiki.gnome.org/msitools) to run this script." : exit 1 : fi : For some reason gerrit is removing ALL spaces from the above lines
https://review.coreboot.org/c/em100/+/62939/comment/1eb68cd7_3aa6ffd9 PS1, Line 28: WD="$( : cd "$(dirname "$(eval echo "$0")")" || exit 1 : pwd : )" Why split this one up, ....
https://review.coreboot.org/c/em100/+/62939/comment/ea693d58_d6ad3174 PS1, Line 52: VERSION="$(strings -e l Program\ Files/DediProg/EM100/EM100.exe | grep -A1 ProductVersion | grep EM100)" ... but not this one.
(I know the answer, but it doesn't seem to make much sense)