Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31841 )
Change subject: Documentation/soc/intel: Add MP Initialization document ......................................................................
Patch Set 3:
(6 comments)
Thank you for this patch.
IMHO, it would be nice to explain a bit more the advantages and inconvenients of each option: as I understand it, the open-source code can initialize less things but it is open-source, as opposed to FSP. And the third option would be a mixture of both worlds I guess?
https://review.coreboot.org/#/c/31841/3/Documentation/soc/intel/mp_init/mp_i... File Documentation/soc/intel/mp_init/mp_init.md:
https://review.coreboot.org/#/c/31841/3/Documentation/soc/intel/mp_init/mp_i... PS3, Line 22: - No need for a hyphen (-), should be a space instead
https://review.coreboot.org/#/c/31841/3/Documentation/soc/intel/mp_init/mp_i... PS3, Line 26: Considering these facts Maybe add a comma after this
https://review.coreboot.org/#/c/31841/3/Documentation/soc/intel/mp_init/mp_i... PS3, Line 34: please put a comma here
https://review.coreboot.org/#/c/31841/3/Documentation/soc/intel/mp_init/mp_i... PS3, Line 35: the same the same task/job
https://review.coreboot.org/#/c/31841/3/Documentation/soc/intel/mp_init/mp_i... PS3, Line 35: make most These two words can be removed
https://review.coreboot.org/#/c/31841/3/Documentation/soc/intel/mp_init/mp_i... PS3, Line 36: Today This can stop being true at some point. Maybe use "As of 2019," instead