Attention is currently required from: Xi Chen, Xixi Chen, Yu-Ping Wu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74544 )
Change subject: vendorcode/mediatek/mt8192: Fix set but unused variables
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74544/comment/524b29e8_192bf16e
PS5, Line 9: BUILD_TIMELESS
What's this?Means build faster?
If you run 'make BUILD_TIMELESS=1' coreboot will not include timestamps. It is an easy way to check if changing code results in diffferent binaries. If they remain the same you can assume no functionality changed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74544
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45d51d53f991556cedd1cc45997d76fc828bceb5
Gerrit-Change-Number: 74544
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 20 Apr 2023 12:43:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-MessageType: comment