Attention is currently required from: Nicholas Chin, Nico Huber, Patrick Rudolph.
Angel Pons has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/82403?usp=email )
Change subject: util/autoport: Streamline external program invocation ......................................................................
Patch Set 5:
(4 comments)
File util/autoport/log_maker.go:
https://review.coreboot.org/c/coreboot/+/82403/comment/01601eff_51c35405?usp... : PS1, Line 46: WriteString
Oh, right, I already have a println in the right place
Done
https://review.coreboot.org/c/coreboot/+/82403/comment/01144ec4_0f675637?usp... : PS1, Line 66: Fatal
I know, it's intentional. Original code did the same but not in all cases (which is odd). […]
Ack
File util/autoport/log_maker.go:
https://review.coreboot.org/c/coreboot/+/82403/comment/a7f5bf9f_d5535bf5?usp... : PS3, Line 162: The following tool
This would be way out of order now. Easy way would be to adapt the text, explain […]
Updated the text for now, as I don't know the golang syntax. I can adapt this in a follow-up if need be.
https://review.coreboot.org/c/coreboot/+/82403/comment/9be6e879_0a94acb2?usp... : PS3, Line 190: ""
This is intentional, as the programs are more likely to be in PATH than in CWD. […]
Done. Also explained why we look for coreboot utils in the utils folder first.