Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jérémy Compostella, Pranava Y N.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85765?usp=email )
Change subject: ec/google/chromeec: Add function to detect barrel charger
......................................................................
Patch Set 1:
(3 comments)
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/85765/comment/4cd092c6_7e49deb7?usp... :
PS1, Line 154: * @return true: if the barrel_charger is present
s/barrel_charger/barrel charger/
Acknowledged
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/85765/comment/c00186fc_8ebff9d7?usp... :
PS1, Line 1024: /*
A few minor suggestions: […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/85765/comment/d3a77b8b_32954da0?usp... :
PS1, Line 1029: */
considering these variables are boolean, I would suggest to use boolean test operator like `!`: […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85765?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9644f0dec057f95bb0a22cdc18edc1a0234ee3a9
Gerrit-Change-Number: 85765
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Thu, 26 Dec 2024 19:20:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com