Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36089 )
Change subject: soc/mediatek/mt8183: Skip fast calibration in recovery mode ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36089/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36089/2//COMMIT_MSG@8 PS2, Line 8: : According MediaTek According to MediaTek
https://review.coreboot.org/c/coreboot/+/36089/2//COMMIT_MSG@10 PS2, Line 10: sill still
https://review.coreboot.org/c/coreboot/+/36089/2/src/soc/mediatek/mt8183/mem... File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/36089/2/src/soc/mediatek/mt8183/mem... PS2, Line 167: vboot_recovery_mode_enabled I'd recommend passing this from board file (romstage), since in SOC implementation we should not rely on vboot (i.e., for non-chromeos, or for devices that do not want to enable vboot).
https://review.coreboot.org/c/coreboot/+/36089/2/src/soc/mediatek/mt8183/mem... PS2, Line 170: if (!recovery_mode) { change to
if (recovery_mode) { printk(BIOS_WARNING, "Skipped loading cached calibration params in recovery mode.\n"); } else if (dparam...) { ... } else { ... }