Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48359 )
Change subject: include/device/device: add comment that config_of_soc never returns NULL
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48359/1/src/include/device/device.h
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/48359/1/src/include/device/device.h...
PS1, Line 388: /* config_of_soc() either returns a non-NULL pointer or dies in the config_of() call. */
I wouldn't expect anyone to read this comment if they won't read the code right above it anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6de6bb1610e823af215436c94ff1a78ff6b86b78
Gerrit-Change-Number: 48359
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 05 Dec 2020 19:46:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment