Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58274 )
Change subject: soc/amd/common/acpi/upep: Add Low Power State Entry Notifications
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/acpi/upep.asl:
https://review.coreboot.org/c/coreboot/+/58274/comment/b3562edd_eb1d7ce9
PS2, Line 11: ENTRY
Should we add _LOW_POWER or something to differentiate these from 7 and 8?
I can replace S0IX with "LOW_POWER" to match exactly in the document.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58274
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3014551f6e281d466628559453a0141a3dd6abad
Gerrit-Change-Number: 58274
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 12 Oct 2021 21:47:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment