Attention is currently required from: Raul Rangel.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56226 )
Change subject: thread: Add missing static inline
......................................................................
Patch Set 4:
(1 comment)
File src/include/thread.h:
https://review.coreboot.org/c/coreboot/+/56226/comment/888c9f90_c28cfdc1
PS4, Line 65: return -1;
nit: I would consider making the thread_run variations call dead_code() rather than just return -1, because they shouldn't be called in the first place when threads aren't enabled. (For the other stuff like cooperate and yield I think it makes sense to keep them as silent no-ops.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56226
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e3cfb55e48737c378bde53ae0e5d7cbf5e41bc3
Gerrit-Change-Number: 56226
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Wed, 14 Jul 2021 22:45:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment