Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Marshall Dawson, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66948 )
Change subject: mb/google/skyrim: Enable CBFS Verification
......................................................................
Patch Set 14:
(1 comment)
File src/soc/amd/mendocino/cbfs_verify.c:
https://review.coreboot.org/c/coreboot/+/66948/comment/5d26f041_5c4e9787
PS3, Line 12: uint32_t mh_offset = FMAP_SECTION_COREBOOT_START - FMAP_SECTION_FLASH_START
: + CONFIG_METADATA_HASH_CBFS_OFFSET;
:
: if (!CONFIG(CBFS_VERIFICATION))
: return 0;
:
: boot_device_init();
: boot_dev = boot_device_ro();
: if (!boot_dev || rdev_readat(boot_dev, &mdata_hash, mh_offset,
: sizeof(mdata_hash)) != sizeof(mdata_hash)) {
: printk(BIOS_ERR, "Error reading metadata hash FMAP section\n");
: return -1;
: }
: metadata_hash_import_anchor(&mdata_hash);
: return 0;
Can delete this once it's part of the vboot infrastructure.
No need for it anymore.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66948
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd22a521a913705af0d2aca17acd1aa069a77f29
Gerrit-Change-Number: 66948
Gerrit-PatchSet: 14
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 21 Oct 2022 20:15:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment