Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45608 )
Change subject: soc/intel/xeon_sp: Improve performance efficiencies ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45608/2/src/soc/intel/xeon_sp/cpx/a... File src/soc/intel/xeon_sp/cpx/acpi.c:
https://review.coreboot.org/c/coreboot/+/45608/2/src/soc/intel/xeon_sp/cpx/a... PS2, Line 706: iio_resource
It seems not necessary since it would need to allocate and free resource for iio_resource.
Right now, `iio_resource` is copied from `hob->PlatformData.IIO_resource[socket]`. There are 2 ways to avoid the copy: ``` const IIO_RESOURCE_INSTANCE *iio_resource = &hob->PlatformData.IIO_resource[socket]; for (int p = PORT_0; p < MAX_PORTS; ++p) current += acpi_create_dmar_ds_pci_br_for_port(current, p, stack, iio_resource, pcie_seg, false, NULL); ``` or you could do this: ``` for (int p = PORT_0; p < MAX_PORTS; ++p) current += acpi_create_dmar_ds_pci_br_for_port(current, p, stack, &hob->PlatformData.IIO_resource[socket], pcie_seg, false, NULL); ```