Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid
......................................................................
Patch Set 59:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/59/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44272/59/src/mainboard/google/volte...
PS59, Line 9: SPD_SOURCES += ddr4-spd-2.hex # ID = 2(0b0010) Parts = H5ANAG6NCMR-XNC
NOTE that this SPD has changed based on a recent DDR4 SPD tool fix (https://review.coreboot.org/c/coreboot/+/44870), so you will want to cherry-pick that patch and then cherry-pick this on top of it so that you have the right bits in ddr-spd-2.hex.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44272
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66
Gerrit-Change-Number: 44272
Gerrit-PatchSet: 59
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mice Lin
mice_lin@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 27 Aug 2020 19:34:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment