build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46263 )
Change subject: nb/amd/pi/*/northbridge.c: Reduce difference ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46263/3/src/northbridge/amd/pi/0066... File src/northbridge/amd/pi/00660F01/northbridge.c:
https://review.coreboot.org/c/coreboot/+/46263/3/src/northbridge/amd/pi/0066... PS3, Line 165: for (link = 0; !res && (link < 8); link++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/46263/3/src/northbridge/amd/pi/0066... PS3, Line 360: else else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/46263/3/src/northbridge/amd/pi/0073... File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/c/coreboot/+/46263/3/src/northbridge/amd/pi/0073... PS3, Line 384: else else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/46263/3/src/northbridge/amd/pi/0073... PS3, Line 1308: new_vendev = ((0x10029850 <= vendev) && (vendev <= 0x1002986F)) ? 0x10029850 : vendev; Comparisons should place the constant on the right side of the test