Attention is currently required from: Subrata Banik, Patrick Rudolph, EricR Lai.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49295 )
Change subject: soc/intel/common: Move L1_substates_control to pcie_rp.h
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/pcie_rp.h:
https://review.coreboot.org/c/coreboot/+/49295/comment/0b94faf1_7ac8ac84
PS4, Line 70: };
Oh, are you talking about why here? So would you like to suggest the place we can put the soc/fsp co […]
Yes, I meant this very file. I know it's all about the RP topic. But that shouldn't
stop us from good software practices.
As `chip.h` is a commonly known concept, I would probably put it into a
`pci_rp_chip.h`. Not a requirement, but it would prevent accidental interleaving
of different things in this file at no additional cost :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49295
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54574b606985e82d00beb1a61cce3097580366a4
Gerrit-Change-Number: 49295
Gerrit-PatchSet: 5
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Sat, 16 Jan 2021 20:07:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment