[coreboot-gerrit] [S] Change in coreboot[master]: soc/amd/acpi/ivrs: Use specific IOMMU resource index on all SOC

[Felix Held (Code Review)]

Attention is currently required from: Arthur Heymans.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75710?usp=email )

Change subject: soc/amd/acpi/ivrs: Use specific IOMMU resource index on all SOC
......................................................................

Patch Set 2:

(1 comment)

File src/soc/amd/common/block/acpi/ivrs.c:

https://review.coreboot.org/c/coreboot/+/75710/comment/6a3fcbb0_b7bb8383 :
PS2, Line 209: 	} else if (dev->link_list->secondary == 0) {
             : 		current = _acpi_fill_ivrs_ioapic(current, (u8 *)GNB_IO_APIC_ADDR,
             : 					PCI_DEVFN(0, 1), 0);
removing this breaks the ivrs support on mandolin/picasso:

AMD-Vi: [Firmware Bug]: : IOAPIC[1] not in IVRS table
AMD-Vi: Disabling interrupt remapping

putting these lines back in place and removing the leading underscore from _acpi_fill_ivrs_ioapic makes it work correctly again.

i think the problem here is that dev is the domain device and not D0F0 on the first bus of the domain where the resource is on, so res will be NULL above