Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32751 )
Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable
......................................................................
Patch Set 8:
Patch Set 8:
Patch Set 8:
This is weird. Why am I not seeing the changed amd/pi/Makefile.inc here? did it change upstream?
Merged already.
Subrata, it's recommended that changes are not submitted within the first 24 hours they are under review. (Technically the Makefile change did not meet that guideline.)
i ack my mistake and will make sure not happening in future. Hope we are good with merged CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32751
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1
Gerrit-Change-Number: 32751
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 31 May 2019 09:54:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment