[coreboot-gerrit] Change in ...coreboot[master]: src/device/Kconfig: Add support for discrete VGA OpROM inclusion at c...

[mikeb mikeb (Code Review)]

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31449 )

Change subject: src/device/Kconfig: Add support for discrete VGA OpROM inclusion at config UI
......................................................................

Patch Set 3:

(1 comment)
> Patch Set 2:
>
> On Sony VPCEH, I load the Nvidia dGPU's VBIOS on coreboot as if I was loading a VBIOS for an Intel card. Is this intended for the case of two graphics adapters that need two different VBIOSes?

Yes.

https://review.coreboot.org/#/c/31449/2/src/device/Kconfig 
File src/device/Kconfig:

https://review.coreboot.org/#/c/31449/2/src/device/Kconfig@618 
PS2, Line 618: 	depends on ARCH_X86 && MULTIPLE_VGA_ADAPTERS
> I find "depends on VGA_BIOS" instead of "depends MULTIPLE_VGA_ADAPTERS" a better way. […]

Good idea Patrick, thank you. Done.