Attention is currently required from: Jonathan Zhang, Johnny Lin, David Hendricks, Christian Walter, Arthur Heymans, Tim Chu.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72441 )
Change subject: soc/intel/xeon_sp/chip_common.c: check SOC_INTEL_PCIE_64BIT_ALLOC
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS6:
Maybe:
static uint8_t is_pci64bit_alloc(void)
{
/*
* For SPR-SP FSP which supports SOC_INTEL_PCIE_64BITS_ALLOC,
* Pci64BitResourceAllocation field does not exist in IIO_UDS HOB.
*/
if CONFIG(SOC_INTEL_PCIE_64BIT_ALLOC)
return 1;
const IIO_UDS *hob = get_iio_uds();
return hob->PlatformData.Pci64BitResourceAllocation;
}
File src/soc/intel/xeon_sp/chip_common.c:
https://review.coreboot.org/c/coreboot/+/72441/comment/de9f735f_be4fc805
PS6, Line 410: #if
why "#if"?
"else" is not needed after "return".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72441
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic33967255baf4675cd72e0db32ef3fb7f5658296
Gerrit-Change-Number: 72441
Gerrit-PatchSet: 6
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 07 Feb 2023 05:20:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment