Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48217 )
Change subject: soc/amd: factor out common SMI/SCI enums and function prototypes ......................................................................
Patch Set 1:
(1 comment)
I only gave this patch a quick glance. In case you didn't look yet, the chromebooks aren't building.
C ramstage/mainboard/google/kahlee/mainboard.o src/mainboard/google/kahlee/mainboard.c: In function 'mainboard_init': src/mainboard/google/kahlee/mainboard.c:128:3: error: implicit declaration of function 'gpe_configure_sci'; did you mean 'dev_configure'? [-Werror=implicit-function-declaration] gpe_configure_sci(gpes, num); ^~~~~~~~~~~~~~~~~ dev_configure
https://review.coreboot.org/c/coreboot/+/48217/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/smi.h:
https://review.coreboot.org/c/coreboot/+/48217/1/src/soc/amd/common/block/in... PS1, Line 38: 0-57 0-57 won't be guaranteed to be consistent