Hello Damien Zammit, Patrick Georgi, Martin Roth, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45517
to look at the new patch set (#2).
Change subject: nb/intel/pineview: Use new mchbar{8,16,32}_and_or() ......................................................................
nb/intel/pineview: Use new mchbar{8,16,32}_and_or()
This fix the overflow error we have with MCHBARx_AND_OR macros: "error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow]"
Change-Id: I5fa844a8a13a75d6d802ca48f72c513bfa16d0a5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- A src/northbridge/intel/common/mchbar_ops.c A src/northbridge/intel/common/mchbar_ops.h M src/northbridge/intel/pineview/Makefile.inc M src/northbridge/intel/pineview/early_init.c M src/northbridge/intel/pineview/pineview.h M src/northbridge/intel/pineview/raminit.c 6 files changed, 417 insertions(+), 344 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/45517/2