[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: Separate power resource for VCM

[Tomasz Figa (Code Review)]

Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )

Change subject: mb/google/volteer: Separate power resource for VCM
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:

https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... 
PS3, Line 345:                 Method (_ON, 0, Serialized)  /* VCPR_ON_: VCM Power On */
What happens if one does the following sequence:
1) Power on the sensor.
2) Power on the VCM.
3) Power off the sensor.
4) Communicate with the VCM.

Would the VCM still work?

https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... 
PS3, Line 347:                         If ((STA == Zero))
Looks like there is something wrong with indentation (spaces, no tabs) in all the code being added in this CL.