Attention is currently required from: Robert Zieba, Jon Murphy, Rob Barnes, Karthik Ramasubramanian, Felix Held.
Hello build bot (Jenkins), Robert Zieba, Raul Rangel, Jon Murphy, Rob Barnes, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/66572
to look at the new patch set (#15).
Change subject: util/amdfwtool/amdfwread: Update relative_offset function ......................................................................
util/amdfwtool/amdfwread: Update relative_offset function
* AMD_ADDR_PHYSICAL refers to physical address in the memory map * AMD_ADDR_REL_BIOS is relative to the start of the BIOS image * AMD_ADDR_REL_TAB is relative to the start of concerned PSP or BIOS tables
Update the relative_offset implementation accordingly. Though AMD_ADDR_REL_SLOT is defined it is not used. Removing that to simplify the relative_offset implementation so that it can be used for both PSP and BIOS firmware tables. Hence update the relative_offset function signature as well.
BUG=None TEST=Build and use amdfwread to read the Soft-fuse bits from Guybrush BIOS image. Observed no changes before and after the changes.
Change-Id: I74603dd08eda87393c14b746c4435eaf2bb34126 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M util/amdfwtool/amdfwread.c 1 file changed, 53 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/66572/15