Attention is currently required from: YH Lin, Mark Hsieh, Felix Held, Zhuohao Lee.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59102 )
Change subject: mb/google/brya/var/gimble: Disable active policy under dptf
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59102/comment/a670a56d_72c2267c
PS2, Line 11: Critical Policy
`power limits`
File src/mainboard/google/brya/variants/gimble/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59102/comment/12cbac0c_b0a1f880
PS2, Line 51: ## Disable Active Policy from baseboard
: register "policies.active" = "{[0] = {.target=DPTF_NONE}}"
This should not be required, there is no policy defined in the baseoboard. For brya, we decided to let each variant fully define its own policies; it led to too much confusion in previous programs
https://review.coreboot.org/c/coreboot/+/59102/comment/be8be82e_e98fce3d
PS2, Line 57: 53.8
Only integral degrees C are supported
https://review.coreboot.org/c/coreboot/+/59102/comment/5c8e24b5_a715bdbe
PS2, Line 79: 250
This could probably be 0, DPTF does not adjust PL2 currently
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9899bf49dfaa63ee96532b5b90464d83e02daeee
Gerrit-Change-Number: 59102
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai
will_tsai@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Wed, 10 Nov 2021 19:26:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment