Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44045 )
Change subject: util/amdfwtool: Refactor APOB_NV requirements ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44045/1/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/44045/1/util/amdfwtool/amdfwtool.c@... PS1, Line 932: apob_idx = find_bios_entry(AMD_BIOS_APOB);
Why do we perform this lookup prior to checking src field?
I have no idea why this was initially written the way it was. My guess is that it was just added a piece at a time and this was a convenient way for the author to do it.
https://review.coreboot.org/c/coreboot/+/44045/1/util/amdfwtool/amdfwtool.c@... PS1, Line 933: if (!fw_table[i].src) {
I'm not sure what scenarios this existing code is trying to cover, but I feel like this code is not […]
I was trying to just make a minor modification since I believe Zheng Bao is refactoring the file, but since that's not done yet, I'll go ahead and update it.