John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager (IOM) device. ......................................................................
Patch Set 4:
(7 comments)
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/tigerlake: Add Type-C IOM device
Would be good to follow this up with some details on IOM such as below. […]
Done
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@9 PS1, Line 9: IO Manageability Engine
Intel Input Output Manager (IOM)
Done
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@10 PS1, Line 10: Kernel IOM : driver refers to this memory resource for port operations.
Separate paragraph about how the driver uses this would be helpful as well. […]
Done
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@10 PS1, Line 10: Kernel IOM : driver
"Intel Input Output Manager (IOM) driver"
Done
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@13 PS1, Line 13: :
Remove?
Done
https://review.coreboot.org/c/coreboot/+/41762/1/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/41762/1/src/soc/intel/tigerlake/acp... PS1, Line 136: Tiger Lake IO Manageability Engine
Input Output Manager (IOM) driver
Done
https://review.coreboot.org/c/coreboot/+/41762/1/src/soc/intel/tigerlake/acp... PS1, Line 137: /* : * IOM preserved MMIO range from 0xFBC10000 to 0xFBC11600. : */
one line?
Done