[coreboot-gerrit] [S] Change in coreboot[master]: util/amdfwtool: Support multiple firmware identifier types

[Paul Menzel (Code Review)]

Attention is currently required from: Bao Zheng, Felix Held, Karthik Ramasubramanian, Matt DeVillier, Raul Rangel, Tim Van Patten.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76585?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: util/amdfwtool: Support multiple firmware identifier types
......................................................................

Patch Set 6:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/76585/comment/ae23eec3_477e96a6 :
PS6, Line 10: only one kind of identifier
Maybe:

… a two byte id as the only kind of identifier.

https://review.coreboot.org/c/coreboot/+/76585/comment/e2a263a9_3873496a :
PS6, Line 11: UUID
Excuse my ignorance, it’s not clear to me why fwid is not unique compared to UUID. Is it only the length?

File util/amdfwtool/amdfwtool.h:

https://review.coreboot.org/c/coreboot/+/76585/comment/fc394f32_b96a2a0c :
PS6, Line 333: typedef enum _fwid_type {
             : 	FWID_TYPE_FWID = 0,
             : 	FWID_TYPE_UUID,
             : } fwid_type_t;
The naming is a bit confusing to me, why a UUID should not be a FWID. If it’s for compliance with the naming in some datasheet, please add a comment.