Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75641?usp=email )
Change subject: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config ......................................................................
mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config
Board IDs are now filled in as part of the signing process, so we don't need to set them in coreboot.
BUG=b:240620735 TEST=Build and check VBOOT_GSC_BOARD_ID is set to ZZCR.
Change-Id: I7dda8ad59046a1dd9a28595e037eda86e91c98df Signed-off-by: Reka Norman rekanorman@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/75641 Reviewed-by: Himanshu Sahdev himanshu.sahdev@intel.com Reviewed-by: Julius Werner jwerner@chromium.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/Kconfig M src/security/vboot/Kconfig 2 files changed, 2 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Himanshu Sahdev: Looks good to me, but someone else must approve Julius Werner: Looks good to me, approved
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index ce10aa7..893ec6a 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -292,10 +292,6 @@ select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_BASEBOARD_NISSA select VBOOT_LID_SWITCH
-config VBOOT_GSC_BOARD_ID - string - default "LBTV" if BOARD_GOOGLE_JOXER - config DIMM_SPD_SIZE default 512
diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig index a998187..a2af5d2 100644 --- a/src/security/vboot/Kconfig +++ b/src/security/vboot/Kconfig @@ -336,6 +336,8 @@ help GSC board ID to be embedded in the GSCVD. Usually each specific mainboard variant has its own. Google engineers can find these in the go/cros-dlm database ("Products"). + The specific board IDs are filled in as part of the production signing process, so + this value is just a default and doesn't need to be set per-variant in coreboot. (Note: This is a completely separate thing from coreboot's `board_id()` function.)
menu "GBB configuration"