Attention is currently required from: Ashish Kumar Mishra, Bora Guvendik, Felix Singer, Shelley Chen.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80334?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brox: Handle GPI_INT pin lower to GPI_WAKE
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brox/variants/baseboard/brox/gpio.c:
https://review.coreboot.org/c/coreboot/+/80334/comment/f6d544be_a48d6797 :
PS3, Line 188: PAD_CFG_GPI_APIC_LOCK(GPP_E2, NONE, LEVEL, INVERT, LOCK_CONFIG),
Just to confirm, since this pin is routed through IOAPIC this will not be part of free irq and hence does not need to be swapped. Can you please confirm?
Just FYI, the next IRQ_WAKE pin is not related to this interrupt.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80334?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8c3d557e888b8d0ceac203f49b702910fba26d6d
Gerrit-Change-Number: 80334
Gerrit-PatchSet: 3
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Comment-Date: Wed, 07 Feb 2024 14:21:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment