Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Daniel Peng has posted comments on this change by Daniel Peng. ( https://review.coreboot.org/c/coreboot/+/85363?usp=email )
Change subject: mb/google/nissa/var/glassway: Modify touch screen ILIT2901 sequence
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85363/comment/96021052_56bbac3b?usp... :
PS4, Line 11: which delay calibration timing
Sorry, I do not understand this part. It’d be great if you rephrased it.
Each panel has its own firmware, and vendor will tune the timing settings in panel firmware and with this CL that would be met the touchscreen power sequence via EE's reports.
https://review.coreboot.org/c/coreboot/+/85363/comment/e4da1118_84a15bcd?usp... :
PS4, Line 12: Change
Double
Same description as above.
https://review.coreboot.org/c/coreboot/+/85363/comment/9e726443_ba74516b?usp... :
PS4, Line 14:
Which firmware version di you test with?
Each firmware of panel might be specific requirement for the project. In this time, the tuned firmware version is 005c_0700.0000.0000.0006.bin.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85363?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I15e30ee72541b4f12b3ec4ea509cb09dc29659ca
Gerrit-Change-Number: 85363
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 10 Dec 2024 01:33:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org