[coreboot-gerrit] Change in coreboot[master]: drivers/i2c/cs35l53: Add driver for generating device in SSDT

[Vitaly Rodionov (Code Review)]

Attention is currently required from: Patrick Georgi, Furquan Shaikh, Subrata Banik, Paul Menzel, Nick Vaccaro, Angel Pons, Robert Chen, Marco Chen, Shon Wang, Name of user not set #1004174, Karthik Ramasubramanian, Xiang Liu.
Vitaly Rodionov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61448 )

Change subject: drivers/i2c/cs35l53: Add driver for generating device in SSDT
......................................................................

Patch Set 11:

(4 comments)

File src/drivers/i2c/cs35l53/chip.h:

https://review.coreboot.org/c/coreboot/+/61448/comment/6784749b_8a8617bc 
PS6, Line 64:  * 0 = Internal Boost
            : 	 * 1 = External Boost
> This isn't needed if you use the enum type (see my comment below). Also applies to other fields.

Done

https://review.coreboot.org/c/coreboot/+/61448/comment/f439ce03_f5bf885c 
PS6, Line 67: unsigned int
> enum cs35l41_boost_type

Done

https://review.coreboot.org/c/coreboot/+/61448/comment/3bbb8726_0b88c232 
PS6, Line 128: 	enum cs35l53_gpio_src gpio_src_select[CS35L53_MAX_GPIOS];
> > > We made the change to using arrays in response to a suggestion from Subrata Banik. […]

Done

File src/drivers/i2c/cs35l53/cs35l53.c:

https://review.coreboot.org/c/coreboot/+/61448/comment/1bd4b002_db797200 
PS6, Line 90: if (!config->gpio_output_enable[0]) {
            : 			printk(BIOS_ERR,
            : 			       "%s: gpio1_output_enable(%d) not set. Enabling for External Boost\n",
            : 				__func__, config->gpio_output_enable[0]);
            : 			config->gpio_output_enable[0] = true;
            : 		}
            : 		if (config->gpio_src_select[0] != GPIO_SRC_GPIO) {
            : 			printk(BIOS_ERR,
            : 			       "%s: Incorrect gpio1_src_select(%d) set. Setting to GPIO_SRC_GPIO for External Boost\n",
            : 			       __func__, config->gpio_src_select[0]);
            : 			config->gpio_src_select[0] = GPIO_SRC_GPIO;
> If External Boost always requires these settings, I'd just overwrite them without printing any error […]

Done