Attention is currently required from: Karthik Ramasubramanian, Shelley Chen, Sowmya Aralguppe, Subrata Banik.
Paul Menzel has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/84185?usp=email )
Change subject: mb/google/brox: Update PL1 Min and remove PL4 modification.
......................................................................
Patch Set 3:
(4 comments)
Patchset:
PS3:
Make it two patches?
Commit Message:
https://review.coreboot.org/c/coreboot/+/84185/comment/1e3dd930_98134959?usp... :
PS3, Line 7: Update
More specific: Increase
https://review.coreboot.org/c/coreboot/+/84185/comment/e5fc493a_6babfa33?usp... :
PS3, Line 7: .
Please remove the dot/period.
https://review.coreboot.org/c/coreboot/+/84185/comment/97232627_35e65c33?usp... :
PS3, Line 10: Remove PL4 value modification based on
: PsysPL3 value.
:
Why?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84185?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib65b517c4cdba04b7e4d15b729ae782f0662717e
Gerrit-Change-Number: 84185
Gerrit-PatchSet: 3
Gerrit-Owner: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 02 Sep 2024 22:22:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No