Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42831 )
Change subject: soc/amd/picasso: Use cbfs to locate the AMD firmware ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42831/2/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/psp_verstage.h:
https://review.coreboot.org/c/coreboot/+/42831/2/src/soc/amd/picasso/psp_ver... PS2, Line 32: #define POSTCODE_AMD_FW_MISSING 0xc9
inconsistent capitalization
Done
https://review.coreboot.org/c/coreboot/+/42831/2/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/42831/2/src/soc/amd/picasso/psp_ver... PS2, Line 89: (uint32_t)boot_dev.base);
I believe you want an absolute address from the spi mapping, correct? The address returned from loc […]
Right. Updated the code here and below to remove the adjustments that are no longer needed.